Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bzlmod): add python.toolchain unit tests #2204

Merged
merged 9 commits into from
Sep 11, 2024

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Sep 8, 2024

With this PR we get rudimentary unit tests for the python bzlmod extension
which allows us to unit test the override behaviour that will become more
complex soon.

Summary:

  • refactor: inline the python_register_toolchains
  • refactor: use toolchain_info to call python_register_toolchains
  • refactor: move the registration out of the main loop
  • refactor: split the parsing of the modules to a separate function
  • test(bzlmod): add python.toolchain module parsing tests

Work towards #2081

tests/python/BUILD.bazel Show resolved Hide resolved
tests/python/python_tests.bzl Outdated Show resolved Hide resolved
aignas and others added 2 commits September 10, 2024 09:07
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
@aignas aignas added this pull request to the merge queue Sep 11, 2024
Merged via the queue into bazelbuild:main with commit c9972d3 Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants